resolving review comments

Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
opencomputeproject · Sep 15, 2023 · f119949 · f119949
1 parent 210cd1b
commit f119949
Showing 1 changed file with 1 addition and 16 deletions.
diff --git a/tests/snappi/test_vlan_traffic.py b/tests/snappi/test_vlan_traffic.py
@@ -11,7 +11,7 @@ def discovery(npu):
     npu.objects_discovery()
 
 
-def test_l2_traffic(npu, dataplane):
+def test_l2_untagged_vlan_traffic(npu, dataplane):
     """
     Creates vlan 10 and adds two ports to the vlan 10 member
     and validates the config using l2 traffic
@@ -43,8 +43,6 @@ def test_l2_traffic(npu, dataplane):
             "attributes": [
                 "SAI_PORT_ATTR_ADMIN_STATE",
                 "true",
-                "SAI_PORT_ATTR_PORT_VLAN_ID",
-                "10",
             ],
         },
         {
@@ -67,8 +65,6 @@ def test_l2_traffic(npu, dataplane):
             "attributes": [
                 "SAI_PORT_ATTR_ADMIN_STATE",
                 "true",
-                "SAI_PORT_ATTR_PORT_VLAN_ID",
-                "10",
             ],
         },
     ]
@@ -138,26 +134,15 @@ def test_l2_traffic(npu, dataplane):
     assert int(rows[0].loss) == 0, "Loss observed"
     assert total_tx > 0, "Tx Frame rate is Zero"
 
-
-@pytest.mark.dependency(depends=["test_l2_traffic"])
-def test_cleanup(self, npu):
     commands = [
         {
             'name': 'vlan_10',
             'op': 'remove',
         },
-        {
-            'name': 'vlan_member_2',
-            'op': 'remove',
-        },
         {
             'name': 'PORT_2',
             'op': 'remove',
         },
-        {
-            'name': 'vlan_member_3',
-            'op': 'remove',
-        },
         {
             'name': 'PORT_3',
             'op': 'remove',