Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cors middleware to all endpoints #362

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Conversation

armanbilge
Copy link
Contributor

@armanbilge armanbilge commented Aug 24, 2021

I'm assuming this is just an oversight? Or if there is a reason for this, apologies.

If this could be fixed in production, would be a big help for typelevel/cats#3972.

Thanks in advance!

@SudharakaP SudharakaP requested a review from znarf August 25, 2021 04:04
Copy link
Member

@znarf znarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to add it everywhere, there should be a single call.

app.use(cors())

Not sure if it's the correct syntax.

@armanbilge
Copy link
Contributor Author

Good point, I'll look into this.

@armanbilge armanbilge requested a review from znarf August 25, 2021 07:41
@armanbilge
Copy link
Contributor Author

@znarf fixed, you were exactly right.

@znarf znarf merged commit 6624448 into opencollective:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants