Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add satellite #101

Merged
merged 40 commits into from
Dec 19, 2023
Merged

add satellite #101

merged 40 commits into from
Dec 19, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 4, 2023 •
edited
Loading

Pull Request

Description

add satellite data into site predictions

  • add satellite class, this is built of the nwp data source class
  • refactored NwpDataSource class to be slightly more generic
  • added in satellite to recent history model
  • take a patch of satellite data, not just one value
  • added forecast horizon as a feature
  • added test satellite data

Screenshot 2023-12-19 at 11 06 31

Fixes ##102

How Has This Been Tested?

  • CI tests

  • added satellite to test configuration + new satellite test data

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title add test satellite add satellite Dec 4, 2023
@peterdudfield peterdudfield marked this pull request as ready for review December 6, 2023 15:02
zakwatts
zakwatts approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Awesome to see satellite improving in the very early forecast horizons.

psp/data_sources/nwp.py Show resolved Hide resolved
psp/data_sources/nwp.py Show resolved Hide resolved
psp/exp_configs/island.py Show resolved Hide resolved
psp/models/recent_history.py Show resolved Hide resolved
psp/models/recent_history.py Outdated Show resolved Hide resolved
psp/models/recent_history.py Show resolved Hide resolved
@peterdudfield peterdudfield merged commit d1e4da0 into main Dec 19, 2023
1 check passed
@peterdudfield peterdudfield deleted the issue/add-sitelite branch December 19, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakwatts zakwatts zakwatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @zakwatts