Replace H with h inside pandas' floor function #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 11 11
Lines 334 334
=======================================
Hits 270 270
Misses 64 64 ☔ View full report in Codecov by Sentry. |
|
You mind checking one more - |
|
This PR fixes the one you mentioned and another one in |
peterdudfield
added a commit
that referenced
this pull request
Mar 4, 2024
* Bump version: 1.0.9 → 1.0.10 [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Bump version: 1.0.10 → 1.0.11 [skip ci] * Replace H with h inside pandas' floor function (#64) Thanks @0xFrama for this * Bump version: 1.0.11 → 1.0.12 [skip ci] * Added Contribution Guide (#65) * added contribution guide * added reference to coding style * Bump version: 1.0.12 → 1.0.13 [skip ci] * docs: add roshnaeem as a contributor for doc (#67) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Test set analysis (#60) * test set analysis * added link to nbviewer in notebook * deleted checkpoints * Delete checkpoints * delete metadata.csv * using metadata from hugging face * remove unused import * Bump version: 1.0.13 → 1.0.14 [skip ci] * docs: add bikramb98 as a contributor for code (#68) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fetches live Enphase data at the moment it is called (#66) * fetches live Enphase data at the moment it is called replace 'user_enphase_api_key' and 'user_enphase_user_id' with the actual Enphase API key and user ID. The make_pv_data function now fetches live data from the Enphase API and combines it with the existing fake PV data This "may" not be from the time of interference, do i add make use of timestamps to enable it? * Added Flag indicating whether to use live Enphase data or not Now the user will have an option whether to use live enphase data or the default data * Updated site object to accomodate is_inverter option + created /inverters/enphase.py file * added environment variables * Bump version: 1.0.14 → 1.0.15 [skip ci] * added init.py in invertors directory * fixed the import of enphase_data --------- Co-authored-by: BumpVersion Action <bumpversion@github-actions> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Peter Dudfield <34686298+peterdudfield@users.noreply.github.com> Co-authored-by: Francesco <30957828+0xFrama@users.noreply.github.com> Co-authored-by: Bikram Baruah <baruahbikram05@gmail.com> Co-authored-by: Aryan Bhosale <36108149+aryanbhosale@users.noreply.github.com>
peterdudfield
added a commit
that referenced
this pull request
Mar 4, 2024
* Bump version: 1.0.9 → 1.0.10 [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Bump version: 1.0.10 → 1.0.11 [skip ci] * Replace H with h inside pandas' floor function (#64) Thanks @0xFrama for this * Bump version: 1.0.11 → 1.0.12 [skip ci] * Added Contribution Guide (#65) * added contribution guide * added reference to coding style * Bump version: 1.0.12 → 1.0.13 [skip ci] * docs: add roshnaeem as a contributor for doc (#67) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- * Test set analysis (#60) * test set analysis * added link to nbviewer in notebook * deleted checkpoints * Delete checkpoints * delete metadata.csv * using metadata from hugging face * remove unused import * Bump version: 1.0.13 → 1.0.14 [skip ci] * docs: add bikramb98 as a contributor for code (#68) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- * fetches live Enphase data at the moment it is called (#66) * fetches live Enphase data at the moment it is called replace 'user_enphase_api_key' and 'user_enphase_user_id' with the actual Enphase API key and user ID. The make_pv_data function now fetches live data from the Enphase API and combines it with the existing fake PV data This "may" not be from the time of interference, do i add make use of timestamps to enable it? * Added Flag indicating whether to use live Enphase data or not Now the user will have an option whether to use live enphase data or the default data * Updated site object to accomodate is_inverter option + created /inverters/enphase.py file * added environment variables * Bump version: 1.0.14 → 1.0.15 [skip ci] * added init.py in invertors directory * fixed the import of enphase_data --------- Co-authored-by: Rosheen Naeem <rosheennaeem4@gmail.com> Co-authored-by: BumpVersion Action <bumpversion@github-actions> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Francesco <30957828+0xFrama@users.noreply.github.com> Co-authored-by: Bikram Baruah <baruahbikram05@gmail.com> Co-authored-by: Aryan Bhosale <36108149+aryanbhosale@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Replaced parameter H with parameter h inside pandas' floor function.
Fixes #62
Checklist: