Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add installation instructions, add other model variables, add ICON in… #37

Merged
merged 3 commits into from
Jan 22, 2024
Merged

add installation instructions, add other model variables, add ICON in… #37

merged 3 commits into from
Jan 22, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 22, 2024 •
edited
Loading

… abbreviations

Pull Request

Description

updates readme
#25

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Jan 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@peterdudfield peterdudfield mentioned this pull request Jan 22, 2024
Closed
zakwatts
zakwatts approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit e59bc38 into main Jan 22, 2024
4 checks passed
@peterdudfield peterdudfield deleted the issue/readme-updates branch January 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakwatts zakwatts zakwatts approved these changes

Assignees

@peterdudfield peterdudfield

Labels
None yet
Projects
No open projects
DESNZ
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @zakwatts