Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add day time metrics also #33

Merged
merged 2 commits into from
Dec 22, 2023
Merged

add day time metrics also #33

merged 2 commits into from
Dec 22, 2023

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

add nighttime stats

How Has This Been Tested?

ran locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review December 22, 2023 09:29
zakwatts
zakwatts approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@peterdudfield peterdudfield merged commit 6ed43b2 into main Dec 22, 2023
2 checks passed
@peterdudfield peterdudfield deleted the add-night-time-metrics branch December 22, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakwatts zakwatts zakwatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
DESNZ
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @zakwatts