Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixes on forecast #92

Merged
merged 1 commit into from
Oct 18, 2023
Merged

bug fixes on forecast #92

merged 1 commit into from
Oct 18, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 18, 2023 •
edited by dfulu
Loading

Pull Request

Description

  • fix for probablistc
  • updated default time for forecast
  • make pvnet default

fixes #90 fixes #91

How Has This Been Tested?

Ran it locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
- make pvnet default
0dd4d2c 
- fix for probablistc
- updated default time for forecast
@peterdudfield peterdudfield self-assigned this Oct 18, 2023
dfulu
dfulu approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@peterdudfield peterdudfield changed the title - make pvnet default bug fixes on forecast Oct 18, 2023
@peterdudfield peterdudfield merged commit 0a4060f into main Oct 18, 2023
2 checks passed
@peterdudfield peterdudfield deleted the issue/forecast-tweaks branch October 18, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu dfulu approved these changes

Assignees

@peterdudfield peterdudfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unassigned variable in probabilistic GSP Pvnet by default
2 participants
@peterdudfield @dfulu