Issue/create new site group #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-labri-tipton
changed the title
src/get_data.py
Outdated
|
|
||
|
|
||
| # create a new site group | ||
| def create_new_site_group(session: Session, site_group_name: str) -> SiteGroupSQL: |
There was a problem hiding this comment.
could you use https://github.com/openclimatefix/pv-site-datamodel/blob/main/pvsite_datamodel/write/user_and_site.py#L29 instead. Then its not duplicated. So you just import this in sites_toolbox.py instead
peterdudfield
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add section to OCF Dashboard to create a new user group.
An error message is given if the site group name is left blank or if the group already exists.
Once a new group is made, it shows some basic site group information. This could be changed.
How Has This Been Tested?
Wrote a test for function that creates a new site group
Ran the code locally
Checklist: