Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/get site group details #64

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Issue/get site group details #64

merged 3 commits into from
Sep 13, 2023

Conversation

rachel-labri-tipton
Copy link
Collaborator

@rachel-labri-tipton rachel-labri-tipton commented Sep 13, 2023 •
edited
Loading

Pull Request

Description

Adds function to get site group details and writes a passing test for the function.

Here's what it looks like in the OCF dashboard:

Screenshot 2023-09-13 at 12 44 13

Screenshot 2023-09-13 at 12 44 39

Fixes #54

How Has This Been Tested?

Ran the code locally and wrote a passing test for get_site_group_details

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

peterdudfield
peterdudfield approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@rachel-labri-tipton rachel-labri-tipton merged commit a9b02ec into main Sep 13, 2023
2 checks passed
@peterdudfield peterdudfield deleted the issue/get-site-group-details branch September 21, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees

@rachel-labri-tipton rachel-labri-tipton

Labels
None yet
Projects
No open projects
DESNZ
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select a sitegroup and show what users are attached, and what sites they have attached
2 participants
@rachel-labri-tipton @peterdudfield