Issue/55 get sites details #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
select how to get site details: site_uuid or client_site_id
test for select site id passing
src/sites_toolbox.py
Outdated
|
|
||
| def get_site_details(session, site_selection): | ||
| """Get the site details for one site""" | ||
| site_uuid = get_site_by_uuid(session=session, site_uuid=site_selection) |
There was a problem hiding this comment.
should this be site=get_site_by_uuid(session=session, site_uuid=site_selection)
src/sites_toolbox.py
Outdated
| site_list= [str(site.client_site_id) for site in get_all_sites(session=dbsession)] | ||
| selected_id = st.selectbox("Sites by client_site_id", site_list) | ||
| selected_id = get_site_by_client_site_id(session=dbsession, client_site_id = selected_id) | ||
| selected_id = str(selected_id.site_uuid) |
There was a problem hiding this comment.
add else:
raise ValueError, if query_method not in ....
There was a problem hiding this comment.
maybe selected_id is actually selected_site_uuid
| return site_details | ||
|
|
||
| def select_site_id(dbsession, query_method): | ||
| if query_method == "site_uuid": |
There was a problem hiding this comment.
could you add a function description to say what this does
There was a problem hiding this comment.
worth perhaps still adding a function descirption, but just do this in a seperate PR
peterdudfield
requested changes
Sep 12, 2023
peterdudfield
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds the feature and tests for getting details for one site, showing metadata.
This is what the metadata looks like. I could use a little help extracting the names from the weird dictionary thing for
DNO,GSP, andRegion(still needs to be added). And looking at it now, some of the metadata could use formatting.:I have added the option for selecting a site by
client_site_idand added a function toget_data.pytoget_site_by_client_site_idbut need some help not getting an error when theclient_site_idis not unique:It'll be easy to add the
client_site_namesearch option to the existing function, but for now, since most of the these names areNone, I wasn't convinced there was much point in adding this option just yet. Maybe it could be added in cases of "not None".Fixes #55
How Has This Been Tested?
Wrote pytests and ran the code locally.
test_get_site_detailsis currently failing. When I removedsite_group_namefrom the dictionary altogether, the test passed. I'm wondering how to get around this.Checklist: