-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather forecast on dashboard #185
base: main
Are you sure you want to change the base?
Conversation
Could you add a screen shot of the UI in the PR? |
You should import the page and add it here |
You need to add herbie to the requirements too |
We discuss int he call today,
|
To help the inital speed up, shold you default to just one init time, perhaps at 00:00 |
This reverts commit 32b5c2f.
* main: fiona==1.9.6 tidy up user page fix india nwp and satellite paths Update README.md fix defaults local case regions add nwp and satellite keys only show user input when needed fix typo add REGION and ENVIROMENT add default options for india and uk for nwp and satellite only select sites on india api users page fix for elexon plot
Could your rename the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add function docs and explain what the parameters are
Good example is here - https://github.com/openclimatefix/pv-site-datamodel/blob/main/pvsite_datamodel/read/generation.py#L76 |
src/weather_forecast.py
Outdated
- init_time (datetime or None): The initialization time for the dataset. | ||
""" | ||
# Adjust the initialization datetime | ||
FH = FastHerbie([init_time], model=model, fxx=range(init_time.hour, 24 + init_time.hour, 1), fast=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be (forecast_date - init_time).hours
or something like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have already set up the init times to be forecast day-1. So to give init times of yesterday for the forecast of today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea but if you say forecast is today, and init time is 06:00 yesterday. fxx = range(6,30) which willget times from 12:00 yesterday to 12:00 today, so not the whole of today
Pull Request
Description
This code will be an addition, to the dashboard and will show weather forecast/ historical data.
This data pulled will be from ECMWF with the help of herbie.
This PR is With india coordinates, will need to make changes if UK needs to be added.
The following is the snap of the webpage:
How Has This Been Tested?
Several tests were ran to see the data being pulled is correct or not
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: