Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nwp viewing page #112

Merged
merged 4 commits into from
Mar 8, 2024
Merged

add nwp viewing page #112

merged 4 commits into from
Mar 8, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Mar 8, 2024

Pull Request

Description

Add a page where NWP data can be explored

How Has This Been Tested?

Tested it locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 27.22%. Comparing base (ecd9dde) to head (683a9c2).
Report is 2 commits behind head on main.

❗ Current head 683a9c2 differs from pull request most recent head f3419e0. Consider uploading reports for the commit f3419e0 to get more accurate results

Files Patch % Lines
src/nwp_page.py 0.00% 72 Missing ⚠️
src/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   29.62%   27.22%   -2.41%     
==========================================
  Files          15       16       +1     
  Lines         827      900      +73     
==========================================
  Hits          245      245              
- Misses        582      655      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield merged commit dabf156 into main Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant