Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/initial-v initial v #1

Merged
merged 3 commits into from
Jun 19, 2024
Merged

feat/initial-v initial v #1

merged 3 commits into from
Jun 19, 2024

Conversation

hminaee-tc
Copy link
Contributor

@hminaee-tc hminaee-tc commented Jun 19, 2024 •
edited
Loading

Changes proposed in this PR:

  • Initial code for pre-commit hooks

  • git work flow to also publish it as a PYPI

  • extra cautionary pre commit hook to check the published version and complain if already exists

    • fail on existing v
    • fail on not committed toml file if v has changed

  • E2E

  • OIDC

  • unit test

  • Extra features

  • verbose

    • log-level
    • h
    • usage
    • dry-run

@hminaee-tc hminaee-tc requested a review from andreouellet June 19, 2024 20:34
andreouellet
andreouellet approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@andreouellet andreouellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hminaee-tc hminaee-tc merged commit e53f801 into main Jun 19, 2024
4 checks passed
@hminaee-tc hminaee-tc deleted the feat/initial-v branch June 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreouellet andreouellet andreouellet approved these changes

Assignees

@hmdevelopermind hmdevelopermind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hminaee-tc @andreouellet @hmdevelopermind