-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep video controls row from overflowing to the left #908
Keep video controls row from overflowing to the left #908
Conversation
For resolutions with small widths, the elements of the video control row would visibly overflow, for example into the main menu. Overflow should now be "hidden" like e.g. in the cutting actions row.
This pull request is deployed at test.editor.opencast.org/908/2022-11-18_14-57-41/ . |
This pull request has conflicts ☹ |
This pull request is deployed at test.editor.opencast.org/908/2022-12-19_08-42-33/ . |
This pull request has conflicts ☹ |
This pull request is deployed at test.editor.opencast.org/908/2023-06-12_07-30-33/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and code looks good!
(And yes, as previous comments say, there are still lots of other problems with narrow screens, but this is an improvement, so why not merge)
For resolutions with small widths, the elements of the video control row
would visibly overflow, for example into the main menu. Overflow should
now be "hidden" like e.g. in the cutting actions row.
(Contains #892)