Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep video controls row from overflowing to the left #908

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Nov 18, 2022

For resolutions with small widths, the elements of the video control row
would visibly overflow, for example into the main menu. Overflow should
now be "hidden" like e.g. in the cutting actions row.

(Contains #892)

For resolutions with small widths, the elements of the video control row
would visibly overflow, for example into the main menu. Overflow should
now be "hidden" like e.g. in the cutting actions row.
@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label Nov 18, 2022
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/908/2022-11-18_14-57-41/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Member

lkiesow commented Nov 23, 2022

This doesn't really seem to work:

Screenshot from 2022-11-23 20-03-54

Screenshot from 2022-11-23 20-03-25

@Arnei
Copy link
Member Author

Arnei commented Nov 24, 2022

Dammit, true enough.

I would like to revise my statement. This PR keeps the row from overflowing towards the left specifically. Notice how Preview Mode moves into the subtitle list
Bildschirmfoto vom 2022-11-24 10-13-31

@Arnei Arnei changed the title Keep video controls row from overflowing Keep video controls row from overflowing to the left Dec 8, 2022
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 19, 2022
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 19, 2022
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/908/2022-12-19_08-42-33/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 19, 2022
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Jun 12, 2023
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/908/2023-06-12_07-30-33/ .
It might take a few minutes for it to become available.

Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and code looks good!

(And yes, as previous comments say, there are still lots of other problems with narrow screens, but this is an improvement, so why not merge)

@Arnei Arnei merged commit cf58558 into opencast:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants