Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors in videoSlice.test.ts #907

Merged
merged 2 commits into from
Nov 23, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix type mismatch for Select labels
Recent dependency updates have caused a type mismatch. This quells the
mismatch by basically replacing null with undefined.
Arnei committed Nov 14, 2022
commit 6cb41ed6360c81ba2f49086279aba09a0c5afe42
2 changes: 1 addition & 1 deletion src/main/SubtitleSelect.tsx
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@ const SubtitleAddButton: React.FC<{languages: {subFlavor: string, title: string}
*/}
<ThemeProvider theme={muiTheme}>
<Select
label={t("subtitles.createSubtitleDropdown-label")}
label={t("subtitles.createSubtitleDropdown-label") ?? undefined}
name="languages"
data={selectData()}
>
2 changes: 1 addition & 1 deletion src/main/SubtitleVideoArea.tsx
Original file line number Diff line number Diff line change
@@ -207,7 +207,7 @@ const VideoSelectDropdown : React.FC<{

<ThemeProvider theme={muiTheme}>
<Select
label={t("subtitleVideoArea.selectVideoLabel")}
label={t("subtitleVideoArea.selectVideoLabel") ?? undefined}
name={dropdownName}
data={selectData()}
/>