Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluos "=" on landing page #838

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Oct 19, 2022

If you blindly copy and paste the query parameter into your browsers address window (and change the mp id), you just land on the landing page again, leaving you a bit stumped before figuring out the typo.

If you blindly copy and paste the query parameter into your browsers
address window (and change the mp id), you just land on the
landing page again, leaving you a bit stumped before figuring out the
typo
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/838/2022-10-19_15-16-01/ .
It might take a few minutes for it to become available.

@Arnei Arnei added type:usability Usability improvements small pull request labels Oct 19, 2022
@lkiesow lkiesow self-assigned this Oct 19, 2022
@Arnei Arnei merged commit 022d24b into opencast:main Oct 19, 2022
@lkiesow
Copy link
Member

lkiesow commented Oct 19, 2022

This should probably have gone through the technical meeting since it wasn't urgent to get this in.

@Arnei
Copy link
Member Author

Arnei commented Oct 20, 2022

Very sorry. Since it was approved so fast I felt vindicated in my assumption that this PR would be absolutely non-controversial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Usability improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants