Subtitle Editor

[Arnei]

Includes all previous PRs for the subtitle editor.

---

This PR aims at integrating the different views of the subtitle editor with the parsed subtitles from Opencast.

• The add subtitles button in the select view now has functionality
• The subtitle select view only shows buttons for languages that already exist in Opencast or have been newly created
• Displays error message for subtitles that could not be parsed (TODO: Make this more user friendly)

[github-actions]

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

[ziegenberg]

Are you gonna squash those commits before merging? :)

[github-actions]

This pull request is deployed at test.editor.opencast.org/638/2022-10-06_15-23-09/ .
It might take a few minutes for it to become available.

[Arnei]

Are you gonna squash those commits before merging? :)

Not planning to. While it's a hell of a lot of commits, most of them actually do relevant stuff, and squashing them all together feels like grossly disregarding the development history.

[github-actions]

This pull request is deployed at test.editor.opencast.org/638/2022-10-07_11-57-50/ .
It might take a few minutes for it to become available.

[github-actions]

This pull request is deployed at test.editor.opencast.org/638/2022-10-07_15-21-49/ .
It might take a few minutes for it to become available.

[lkiesow]

Sorry Arne, I found one more bug in the subtitle editor. But I hope this one is easy to fix:

HTML seems to be escaped, saved and then escaped when you load it again.

[lkiesow]

Interesting, the player also does weird things with this as input:

[Arnei]

HTML seems to be escaped, saved and then escaped when you load it again.

Do you have more details on that? I could not reproduce that.

Although I could get the div tags to disappear after saving and reloading

[github-actions]

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

[github-actions]

This pull request is deployed at test.editor.opencast.org/638/2022-10-12_14-55-29/ .
It might take a few minutes for it to become available.

[lkiesow]

Do you have more details on that? I could not reproduce that.

opencast-editor-html.mp4

[Arnei]

Thanks, now I can reproduce it too :)

[lkiesow]

As discussed in Matrix, I'm pretty happy with the current state of the new subtitle editor. The minor problem with the potential double-encoding of HTML content in subtitles, which is a somewhat obscure problem normal users are unlikely to face I'm going to ignore here.
Given that this is still merged as beta, and hidden by default, and that we have a few suggestions for further improvements for the future already, I think that's okay,
Iignoring that and merging it like this so that users can already start tesing that (and probably find more issues :D) probably makes more sense instead of waiting for just the next merge conflict. We will spend some more time on this anyway. Of course, I will create an issue for that.