Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download subtitle files #1185

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Download subtitle files #1185

merged 2 commits into from
Oct 31, 2023

Conversation

Pavol-Beskid
Copy link

  • added a download button to SubtitleEditor view for downloading subtitles in WebVTT file.

@github-actions
Copy link

Hi @Pavol-Beskid
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@Arnei Arnei added the type:feature A new feature or feature request label Oct 26, 2023
@Arnei
Copy link
Member

Arnei commented Oct 26, 2023 •
edited
Loading

Hi Pavol-Beskid,
thanks for contributing! I'll try and see to it that this gets merged before the end of the month. Please do file an ICLA as requested by the github-actions comment.

Arnei
Arnei approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks code and does what it says, approved from my side.

Short FYI: You don't need to provide a translation for every language, only en-US is fine. Translation is then later done in CrowdIn.

@Arnei
Copy link
Member

Arnei commented Oct 26, 2023 •
edited
Loading

Quick screen grab (for people who want to see how it looks, but don't want to install this PR themselves):

Bildschirmaufzeichnung.vom.2023-10-26.09-14-14.webm

@gregorydlogan
Copy link
Member

ICLA is now on file, so this is good to go

@Arnei Arnei merged commit 6757d7e into opencast:main Oct 31, 2023
7 of 8 checks passed
@Arnei Arnei mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arnei Arnei Arnei approved these changes

Assignees
No one assigned
Labels
type:feature A new feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pavol-Beskid @Arnei @gregorydlogan