Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtitle editor, make input fields better visible #932

Closed
cgruber-uos opened this issue Dec 7, 2022 · 2 comments · Fixed by #973
Closed

Subtitle editor, make input fields better visible #932

cgruber-uos opened this issue Dec 7, 2022 · 2 comments · Fixed by #973

Comments

@cgruber-uos
Copy link
Contributor

Input fields for subtitle text and time marks are nicely formated in dark mode: Input fields have other background colors than the page background and a clear visible border:

2022-12-07 11_54_15-Greenshot

We should make similar things with the "default" / white skin:

2022-12-07 11_54_14-Greenshot

Either making the input background light gray or the general background (then for all pages)!
@lkiesow
Copy link
Member

lkiesow commented Dec 23, 2022

I like the idea of having a slightly gray background and white input fields in light mode. If we make the input gray, they could be mistaken for deactivated fields.

@lkiesow lkiesow mentioned this issue Dec 23, 2022
Merged
7 tasks
@dennis531
Copy link
Collaborator

image

I set the background color to"whitesmoke" in light mode.

dennis531 pushed a commit to dennis531/opencast-editor that referenced this issue Feb 1, 2023
Improve visibility of input fields
7e9b2f7 
Shows a slightly grey (whitesmoke) background and white input fields in light mode.

This changes should make the input fields better visible, since they are currently displayed in the same background color.

Resolves opencast#932
@dennis531 dennis531 mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve visibility of input fields dennis531/opencast-editor
3 participants
@lkiesow @dennis531 @cgruber-uos