Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #615

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Maintenance #615

merged 4 commits into from
Aug 14, 2023

Conversation

JulianKniephoff
Copy link
Member

Some maintenance things. See commit messages for more details.

@JulianKniephoff JulianKniephoff added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 11, 2023
@JulianKniephoff JulianKniephoff requested a review from Arnei August 11, 2023 14:59
That `when` was in the wrong place.
This makes the tests work with newer Java versions (tested with 20)
and also fixes a warning about invalid POMs during the Maven build.
When building with Maven's `-T` option the build was warning
about two plugins that might not be thread safe.

This patch updates one and removes the other.

Regarding static weaving: It might be interesting to look at
at some point, but it's "only" for performance and Opencast removed
this as well: opencast/opencast#3031.
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable commits that don't appear to be breaking anything (tested only with OC13).

@JulianKniephoff JulianKniephoff merged commit 3c830ae into opencast:master Aug 14, 2023
@JulianKniephoff JulianKniephoff deleted the maintenance branch August 14, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants