-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add matomo to app #50
Conversation
46cbee5
to
682043d
Compare
682043d
to
6d60ca0
Compare
6d60ca0
to
d8c49eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
import { getVirtualLabsOfUser } from '@/services/virtual-lab/labs'; | ||
import VirtualLabDashboard from '@/components/VirtualLab/VirtualLabDashboard'; | ||
|
||
export const metadata: Metadata = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. LGTM.
} catch (error: any) { | ||
setSubscribeResult({ | ||
status: 'error', | ||
msg: 'message' in (error as { message: string }) ? error.message : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an assertErrorMessage
function somewhere in utils that does this.
NOTE: for better UX and also for matomo dashboard navigation, it's better to add the
metadata
for each page (basically the title and description will be enough for the time being), so this will be address later or progressively while developing @pgetta @g-bar @tolokoban