Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matomo to app #50

Merged
merged 1 commit into from
Feb 19, 2025
Merged

add matomo to app #50

merged 1 commit into from
Feb 19, 2025

Conversation

bilalesi
Copy link
Collaborator

@bilalesi bilalesi commented Feb 19, 2025

  1. add matomo analytics to the app
  2. allow the name to be optional for the newsletter subscription
  3. add consent modal for cookies
  4. fix small style for injection button
  5. add env vars of matomo

NOTE: for better UX and also for matomo dashboard navigation, it's better to add the metadata for each page (basically the title and description will be enough for the time being), so this will be address later or progressively while developing @pgetta @g-bar @tolokoban

@bilalesi bilalesi requested a review from g-bar February 19, 2025 12:36
Copy link
Collaborator

@pgetta pgetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

import { getVirtualLabsOfUser } from '@/services/virtual-lab/labs';
import VirtualLabDashboard from '@/components/VirtualLab/VirtualLabDashboard';

export const metadata: Metadata = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@g-bar g-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. LGTM.

} catch (error: any) {
setSubscribeResult({
status: 'error',
msg: 'message' in (error as { message: string }) ? error.message : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an assertErrorMessage function somewhere in utils that does this.

@bilalesi bilalesi merged commit 7028a60 into develop Feb 19, 2025
4 of 5 checks passed
@bilalesi bilalesi deleted the matomo-integration branch February 19, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants