Skip to content

Commit

Permalink
drm/udl: Add ARGB8888 as a format
Browse files Browse the repository at this point in the history
Even though the UDL driver converts to RGB565 internally (see
pixel32_to_be16() in udl_transfer.c), it advertises XRGB8888 for
compatibility. Let's add ARGB8888 to that list.

This makes UDL devices work on ChromeOS again after commit
c91acda ("drm/gem: Check for valid formats"). Prior to that
commit things were "working" because we'd silently treat the ARGB8888
that ChromeOS wanted as XRGB8888.

Fixes: c91acda ("drm/gem: Check for valid formats")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240227141928.1.I24ac8d51544e4624b7e9d438d95880c4283e611b@changeid
  • Loading branch information
dianders committed Mar 5, 2024
1 parent daf8739 commit 95bf25b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/udl/udl_modeset.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ static int udl_handle_damage(struct drm_framebuffer *fb,
static const uint32_t udl_primary_plane_formats[] = {
DRM_FORMAT_RGB565,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_ARGB8888,
};

static const uint64_t udl_primary_plane_fmtmods[] = {
Expand Down

0 comments on commit 95bf25b

Please sign in to comment.