fetch-apis-assigned-to-company #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-wunmi
reviewed
Jan 18, 2024
| companyId?: string, | ||
| ) { | ||
| const company = await this.companyRepository.findOneOrFail({ | ||
| where: { id: companyId ?? ctx.activeCompany.id }, |
There was a problem hiding this comment.
you should check if the current user is an api provider before fetching by companyId, dont want anyone to supply an id and be able to fetch data unrelated to them
There was a problem hiding this comment.
Actually the service would serve 2 different endpoints. Forgot while I worked
the-wunmi
reviewed
Jan 18, 2024
| @@ -88,6 +88,21 @@ export class APIController { | |||
| ); | |||
| } | |||
|
|
|||
| @Put('company/:companyId') | |||
| @UsePipes(IValidationPipe) | |||
| @RequireTwoFA() | |||
There was a problem hiding this comment.
this means users would need to provide a 2fa code to access this endpoint, dont think its idle for a get request, also seeing you doing a Put instead of Get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.