Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updated openapi-response-validator to ^4.0.0 (was ^3.8.2) #79

Merged
merged 1 commit into from
May 22, 2020
Merged

chore(deps): updated openapi-response-validator to ^4.0.0 (was ^3.8.2) #79

merged 1 commit into from
May 22, 2020

Conversation

mvegter
Copy link
Contributor

@mvegter mvegter commented May 22, 2020

No description provided.

@mvegter
Copy link
Contributor Author

mvegter commented May 22, 2020

@rwalle61 apologies for this weird second pull request, apparently force pushing on the master branch is not fully working in a PR. So I created a branch and opened a new pull request.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files          33       33           
  Lines         633      633           
  Branches       51       51           
=======================================
  Hits          604      604           
  Misses         27       27           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d3fcf...0c37c39. Read the comment docs.

@rwalle61
Copy link
Collaborator

Np, thanks for this update to #78

As this doesn't change our functionality, I would normally not publish it until we are publishing functional changes too. Are you happy to wait, or do you think we should publish immediately?

@rwalle61 rwalle61 merged commit af92ffb into openapi-library:master May 22, 2020
@mvegter
Copy link
Contributor Author

mvegter commented May 22, 2020

It's true that it is not a real change but the validator dependency (and it's transitive dependencies) is an important one. Personally I would make an exception for this case and have a release.

@rwalle61 rwalle61 mentioned this pull request May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants