Skip to content

Commit

Permalink
skip compiling test
Browse files Browse the repository at this point in the history
  • Loading branch information
dw511214992 committed Jul 22, 2022
1 parent 8b397cc commit 331207c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion eng/mgmt/automation/generate_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def generate(


def compile_package(sdk_root: str, group_id: str, module: str) -> bool:
command = 'mvn --no-transfer-progress clean verify package -f {0}/pom.xml -Dmaven.javadoc.skip -Dgpg.skip -Drevapi.skip -pl {1}:{2} -am'.format(
command = 'mvn --no-transfer-progress clean verify package -f {0}/pom.xml -Dmaven.javadoc.skip -Dgpg.skip -DskipTestCompile -Drevapi.skip -pl {1}:{2} -am'.format(
sdk_root, group_id, module)
logging.info(command)
if os.system(command) != 0:
Expand Down
2 changes: 1 addition & 1 deletion eng/mgmt/automation/generate_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def generate(

def compile_package(sdk_root, module) -> bool:
if os.system(
'mvn --no-transfer-progress clean verify package -f {0}/pom.xml -Dmaven.javadoc.skip -Dgpg.skip -Drevapi.skip -pl {1}:{2} -am'.format(
'mvn --no-transfer-progress clean verify package -f {0}/pom.xml -Dmaven.javadoc.skip -Dgpg.skip -DskipTestCompile -Drevapi.skip -pl {1}:{2} -am'.format(
sdk_root, GROUP_ID, module)) != 0:
logging.error('[COMPILE] Maven build fail')
return False
Expand Down
2 changes: 0 additions & 2 deletions sdk/parents/azure-client-sdk-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@
<!-- key in on the properties as well. These properties ensure that skipping compiles doesn't result -->
<!-- in unexpected plugin changes outside of maven-compiler-plugin. -->
<skipCompile>false</skipCompile>
<skipTestCompile>false</skipTestCompile>

<compiler.proc>none</compiler.proc>
</properties>
Expand Down Expand Up @@ -523,7 +522,6 @@
<showWarnings>true</showWarnings>
<failOnWarning>true</failOnWarning>
<skipMain>${skipCompile}</skipMain>
<skip>${skipTestCompile}</skip>
<compilerArgs combine.children="append" combine.self="append">
<!-- https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javac.html#xlintwarnings -->
<arg>-Xlint:cast</arg>
Expand Down

0 comments on commit 331207c

Please sign in to comment.