Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appplatform.json #2333

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Update appplatform.json #2333

merged 1 commit into from
Apr 15, 2021

Conversation

PhoenixHe-NV
Copy link

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Apr 15, 2021

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule Message
R4009 - RequiredReadOnlySystemData The response of operation:'Services_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L20
R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L407
R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L628
R4009 - RequiredReadOnlySystemData The response of operation:'Apps_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L788
R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1110
R4009 - RequiredReadOnlySystemData The response of operation:'Certificates_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1395
R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1655
R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L1994
R4009 - RequiredReadOnlySystemData The response of operation:'Services_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L60
R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L447
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄CredScan inProgress [Detail]
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Apr 15, 2021

Swagger Generation Artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from beb550a. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.84 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.AppPlatform [View full logs]  [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from beb550a. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️appplatform/mgmt/2020-07-01/appplatform [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] ### New Content
    info	[Changelog]
    info	[Changelog] - New const `Inbound`
    info	[Changelog] - New const `Outbound`
    info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
    info	[Changelog] - New struct `RequiredTraffic`
    info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    info	[Changelog]
  • ️✔️preview/appplatform/mgmt/2020-11-01-preview/appplatform [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/appplatform/mgmt/2019-05-01-preview/appplatform [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] ### New Content
    info	[Changelog]
    info	[Changelog] - New const `Deleting`
    info	[Changelog] - New const `DeploymentResourceProvisioningStateDeleting`
    info	[Changelog] - New const `Outbound`
    info	[Changelog] - New const `Inbound`
    info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
    info	[Changelog] - New struct `RequiredTraffic`
    info	[Changelog] - New field `Sku` in struct `DeploymentResource`
    info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
    info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
    info	[Changelog]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from beb550a. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️appplatform [View full logs]  [Release Schema Changes]
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@PhoenixHe-NV PhoenixHe-NV merged commit beb550a into master Apr 15, 2021
azure-sdk pushed a commit that referenced this pull request Apr 15, 2021
azure-sdk pushed a commit that referenced this pull request Apr 16, 2021
azure-sdk pushed a commit that referenced this pull request Apr 19, 2021
azure-sdk pushed a commit that referenced this pull request Apr 20, 2021
azure-sdk pushed a commit that referenced this pull request Apr 22, 2021
azure-sdk pushed a commit that referenced this pull request Apr 23, 2021
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
azure-sdk pushed a commit that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant