feat: add row level access control #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow or deny edits/deletes per row Change-Id: Ie17e70ac51327c68973f3821bccf59b9bceb1e1b
Change-Id: Iebb51b0e154c5a3ceb451e53b268c3ca71d65753
More logical since input data is expected to be tibble. When implementing custom canEditRow() and canDeleteRow() logic, tibble is therefore the expected data type. Change-Id: I53b7346f737c817ff4e0379b3d567740baf7ad49
- Always allow to modify / delete newly inserted rows - Allow to pass on boolean values Change-Id: I552a7a31babb554bcd7aeb6337b19fd6d76968e3
Gives a more consistent user-intuitive look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow or deny edits/deletes per row
Resolves feature request: #7
Shorter delay when modifying large datasets.
Slightly slows down initial loading of the data (since logic for each row needs to be evaluated on whether or not to add buttons). However the user experience is generally better because of the above improvement.