Change architecture to separate parser logic from server logic (untested) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Gao <emiapwil@gmail.com>
Signed-off-by: Kai Gao <emiapwil@gmail.com>
Signed-off-by: Kai Gao <emiapwil@gmail.com>
Signed-off-by: Kai Gao <emiapwil@gmail.com>
Refactored from estimate_throughput.py
Now, works with any Parser object that supports a function construct_from_flows(flows_list) that returns a dict with "A" matrix, "c" vector, and "RTT".
giralt
reviewed
Apr 14, 2022
giralt
reviewed
Apr 18, 2022
fno2010
reviewed
Apr 25, 2022
| Currently, only `G2_MININET` is supported. | ||
| """ | ||
|
|
||
| SOLVER = "jensen" |
There was a problem hiding this comment.
Maybe "num" is a better name for the solver, as this solver uses the "Network Utility Maximization (NUM)" model to do the prediction.
There was a problem hiding this comment.
Never see the name is changed. Re-opened this conversation.
giralt
reviewed
Apr 28, 2022
fno2010
reviewed
May 2, 2022
|
Overall, the PR looks good to me. But some files are still using hard TAB indents. |
giralt
reviewed
May 9, 2022
| * This script assumes that the configuration files are located at | ||
| "input/g2.conf" and "output/input_routing.conf". If this is not the case, | ||
| then change the variables g2fp_str and infp_str | ||
| * This script estimates RTT by summing up the delays of each link. This is |
There was a problem hiding this comment.
Suggest changing slightly the language. Instead of:
"This is not accurate!!! But, since..."
Say something like:
"This is for now a first order approximation, since queuing and processing delay are not taken into account."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated the parser logic from the server logic (thank you Kai for his comment on #24 (openalto/ietf-hackathon#24)). Now, the parser lives in a
G2Parserclass that is used in the server. Note that parser code can easily be swapped out, if we want to develop another parser, as long as the parser implements a methodconstruct_from_flows(flows_list).