Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find Makefile+Call Stack (most recent call first): CMakeLists.txt:151 (add_core) #199

Closed
reginalluna opened this issue Mar 12, 2020 · 23 comments

Comments

@reginalluna
Copy link

reginalluna commented Mar 12, 2020

Issue summary

I tried many times to build [retro] through CMake, but the error is keep showing up. I don't know how to fix them.
image

image

[Put a detailed description of the issue here.]

System information

  • [Gym Retro version]: the newest
@endrift
Copy link
Contributor

endrift commented Mar 13, 2020

You need to do a proper git checkout, this looks like you downloaded and extracted a zip file of the repository

@reginalluna
Copy link
Author

reginalluna commented Mar 13, 2020

You need to do a proper git checkout, this looks like you downloaded and extracted a zip file of the repository

Hi endriftm

I used GitDesktop to clone this repository. About the git checkout, which branch should I get in?
Is it the branch I should get in?

@reginalluna
Copy link
Author

You need to do a proper git checkout, this looks like you downloaded and extracted a zip file of the repository

And now I'm having the problem like this
image

@christopherhesse
Copy link
Collaborator

It looks like your python may also be broken. You may want to reinstall python.

If you follow the instructions for building from source here: https://retro.readthedocs.io/en/latest/developing.html building retro should work (but the instructions are not extensively tested).

Can I ask why you are installing retro from source? Most users do not need to do this.

@reginalluna
Copy link
Author

It looks like your python may also be broken. You may want to reinstall python.

If you follow the instructions for building from source here: https://retro.readthedocs.io/en/latest/developing.html building retro should work (but the instructions are not extensively tested).

Can I ask why you are installing retro from source? Most users do not need to do this.

Hi Christopherhesse,

I'm confused about the instruction of using Gym-Retro (I'm an artist so I don't have that much knowledge about computer science hope you don't mind.)

I'm following the tutorial https://www.youtube.com/watch?v=CFa6NhLgeL0 here, and I'm stopping at

pip3 install -e .

for three days.

@reginalluna
Copy link
Author

It looks like your python may also be broken. You may want to reinstall python.

If you follow the instructions for building from source here: https://retro.readthedocs.io/en/latest/developing.html building retro should work (but the instructions are not extensively tested).

Can I ask why you are installing retro from source? Most users do not need to do this.

Should I uninstall all the python on my computer?

@christopherhesse
Copy link
Collaborator

I'm afraid we don't really provide python support here, but you should probably uninstall and reinstall all the pythons.

I took a quick look at that video and I don't know why the person installs retro from source, I think you could accomplish the same thing by following the getting started guide here: https://retro.readthedocs.io/en/latest/getting_started.html and then doing the import_sega_classics script mentioned in the video to get the sonic ROM installed.

Installing from source if you don't have to do it will be a huge pain.

@reginalluna
Copy link
Author

I'm afraid we don't really provide python-support here, but you should probably uninstall and reinstall all the pythons.

I took a quick look at that video and I don't know why the person installs retro from source, I think you could accomplish the same thing by following the getting started guide here: https://retro.readthedocs.io/en/latest/getting_started.html and then doing the import_sega_classics script mentioned in the video to get the sonic ROM installed.

Installing from source if you don't have to do it will be a huge pain.

Hi Christopherhess,

Thanks so much for your advice. I'm uninstalling all the python stuff first and follow the step you provide. I will let you know if I find any trouble next. xxx

@reginalluna
Copy link
Author

I'm afraid we don't really provide python support here, but you should probably uninstall and reinstall all the pythons.

I took a quick look at that video and I don't know why the person installs retro from source, I think you could accomplish the same thing by following the getting started guide here: https://retro.readthedocs.io/en/latest/getting_started.html and then doing the import_sega_classics script mentioned in the video to get the sonic ROM installed.

Installing from source if you don't have to do it will be a huge pain.

Hi Christopherhess,

it doesn't work when I typed

pip install -e .

image

Do I make anything wrong there?

I tried to follow the instruction on getting_started but I'm confusing about the way to creat . Where should I put

import retro
env = retro.make(game='Airstriker-Genesis')

@reginalluna
Copy link
Author

I'm afraid we don't really provide python support here, but you should probably uninstall and reinstall all the pythons.

I took a quick look at that video and I don't know why the person installs retro from source, I think you could accomplish the same thing by following the getting started guide here: https://retro.readthedocs.io/en/latest/getting_started.html and then doing the import_sega_classics script mentioned in the video to get the sonic ROM installed.

Installing from source if you don't have to do it will be a huge pain.

Hi Christopherhess,

When I run pip install gym-retro the problem shows up.
image

@christopherhesse
Copy link
Collaborator

Oh, we don't have python 3.8 wheels yet, you should make sure you are using python 3.7

@reginalluna
Copy link
Author

reginalluna commented Mar 13, 2020 via email

@christopherhesse
Copy link
Collaborator

Maybe but it's going to be pretty confusing if you do.

@reginalluna
Copy link
Author

I'm afraid we don't really provide python support here, but you should probably uninstall and reinstall all the pythons.

I took a quick look at that video and I don't know why the person installs retro from source, I think you could accomplish the same thing by following the getting started guide here: https://retro.readthedocs.io/en/latest/getting_started.html and then doing the import_sega_classics script mentioned in the video to get the sonic ROM installed.

Installing from source if you don't have to do it will be a huge pain.

I tried to run pip3 install -e . on LinuxOS, but it doesn't work still.

@reginalluna
Copy link
Author

I'm afraid we don't really provide python support here, but you should probably uninstall and reinstall all the pythons.
I took a quick look at that video and I don't know why the person installs retro from source, I think you could accomplish the same thing by following the getting started guide here: https://retro.readthedocs.io/en/latest/getting_started.html and then doing the import_sega_classics script mentioned in the video to get the sonic ROM installed.
Installing from source if you don't have to do it will be a huge pain.

I tried to run pip3 install -e . on LinuxOS, but it doesn't work still.

Ok, the code sudo apt-get install zlib1g-dev did help. Let me see if it can run well or not.

@christopherhesse
Copy link
Collaborator

I think you should probably not run pip install -e at all. As the getting started guide says, you should probably run pip3 install gym-retro

@reginalluna
Copy link
Author

I think you should probably not run pip install -e at all. As the getting started guide says, you should probably run pip3 install gym-retro

It works on the Ubuntu (VM), but O'm still not sure whether it can work on windows10 or not.

Here' the new problem I have => 'module' object has no attribute 'make'

@christopherhesse
Copy link
Collaborator

pip install gym-retro should work on windows, I use it on my windows 10 machine, and I've never gotten retro to build from source on there. It won't work with python 3.8 though, just 3.7 and 3.6, until this issue is fixed: #197

@reginalluna
Copy link
Author

pip install gym-retro should work on windows, I use it on my windows 10 machine, and I've never gotten retro to build from source on there. It won't work with python 3.8 though, just 3.7 and 3.6, until this issue is fixed: #197

pip install gym-retro can work on windows 10, but when I use pip3 install -e . it causes a crushing. Let me try to run it on Ubuntu first then check it on win10 later.

@christopherhesse
Copy link
Collaborator

I am saying don't use pip3 install -e

@reginalluna
Copy link
Author

I am saying don't use pip3 install -e

Oh, ok. It works on Ubuntu anyway. But, I'm having a new proble of AttributeError: 'module' object has no attribute 'make'
now

@christopherhesse
Copy link
Collaborator

You're probably in some folder that has a folder named retro in it, change to a different directory.

@christopherhesse
Copy link
Collaborator

Closing due to lack of activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants