Skip to content

Commit

Permalink
fix(cli/chat): only send params when set (#2077)
Browse files Browse the repository at this point in the history
  • Loading branch information
RobertCraigie authored Feb 3, 2025
1 parent 7a6517d commit 688b223
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/openai/cli/_api/chat/completions.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,17 @@ def create(args: CLIChatCompletionCreateArgs) -> None:
"messages": [
{"role": cast(Literal["user"], message.role), "content": message.content} for message in args.message
],
"n": args.n,
"temperature": args.temperature,
"top_p": args.top_p,
"stop": args.stop,
# type checkers are not good at inferring union types so we have to set stream afterwards
"stream": False,
}
if args.temperature is not None:
params['temperature'] = args.temperature
if args.stop is not None:
params['stop'] = args.stop
if args.top_p is not None:
params['top_p'] = args.top_p
if args.n is not None:
params['n'] = args.n
if args.stream:
params["stream"] = args.stream # type: ignore
if args.max_tokens is not None:
Expand Down

0 comments on commit 688b223

Please sign in to comment.