Added net8.0 as a supported target framework for OpenAI #272 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanossiloko
requested review from
joseharriaga and
trrwilson
as code owners
Barry-Eventio
approved these changes
Dec 5, 2024
Barry-Eventio
approved these changes
Jan 17, 2025
joseharriaga
approved these changes
Jan 17, 2025
|
👀 |
|
Thank you for your contribution, @armanossiloko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I honestly do not know why this has not been done by now. NET 8 is the latest dotnet version and is also LTS.
All the examples and tests projects are already targeting
net8.0so basically the only the thing needing to be done is add it to the supported target frameworks in the OpenAI.csprojBesides, from what I understood, this would help with #272 and the change proposed in this PR was also suggested by @RogerBarreto in #98, however that PR was never updated since August.