Set offwidth and offheight properly before make MjrContext to support width > 640 or height > 480 in offscreen rendering #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo-rnd-thoughts
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Looks good to merge
@YouJiacheng Could you update the title to make it more helpful
YouJiacheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to minimize diff in this PR, thus there are some boilerplate codes.
Fix #3043
We might use
self._widthinstead ofself.widthto inform user not modifying it.Alternatively we can override
__setattr__to ensure given attribute can only write once.@rodrigodelazcano