JSON-LD: Remove quotes in headlines & descriptions #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a text contains "quotes", this text will create a syntax error for JSON. Either the quotes need to be masked or removed. I decided to remove them with translate().
tomschr
added
cat-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a text contains "quotes", this text will create a syntax error for JSON. Either the quotes need to be masked or removed. I decided to remove them with translate().
First discovered for
/de-de/sles/15-SP1/html/SLES-all/cha-apache2.html.Solution
This PR adds the XPath function
translate()to remove and quotes. Although this is not entirely accurate, it's probably the easiest and fastest solution.