Set nofollow on user-generated links
#3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To disincentivize spamdexing, links in user-generated content should be disavowed by annotation with `rel="nofollow"` attributes: - https://en.wikipedia.org/wiki/Nofollow Automated spam has already targeted OSEM in the wild: - SeaGL/organization#274 Ideally link annotation would be performed during Markdown rendering or a single sanitization pass, but this is currently an unresolved issue: - vmg/redcarpet#720
hennevogel
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves
To disincentivize spamdexing, links in user-generated content should be disavowed by annotation with
rel="nofollow"attributes. Automated spam has already targeted OSEM in the wild.Changes proposed in this pull request
Pass rendered markdown through the
NoFollowscrubber already available in Rails.Ideally this would be done during markdown rendering or in a single sanitization pass; see the unresolved discussion at vmg/redcarpet#720.