Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webui] Show if request is a new package submission #3960

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

ChrisBr
Copy link
Member

@ChrisBr ChrisBr commented Oct 6, 2017

in the request table on the user and group overview.

new_package_request_table

@ismail please have a look

@hennevogel hennevogel added the Frontend Things related to the OBS RoR app label Oct 6, 2017
@ismail
Copy link
Contributor

ismail commented Oct 6, 2017

I would prefer if it said "new package" instead of just new, but otherwise looks good.

@ChrisBr ChrisBr force-pushed the feature/show_new_package branch from fca3335 to 2f228fd Compare October 9, 2017 08:50
in the request table on the user and group overview.
@ChrisBr ChrisBr force-pushed the feature/show_new_package branch from 2f228fd to 989854f Compare October 9, 2017 08:50
@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #3960 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3960      +/-   ##
==========================================
+ Coverage   89.21%   89.22%   +<.01%     
==========================================
  Files         309      309              
  Lines       18271    18278       +7     
==========================================
+ Hits        16301    16308       +7     
  Misses       1970     1970
Flag Coverage Δ
#api 80.49% <20%> (-0.03%) ⬇️
#rspec 69.84% <100%> (+0.01%) ⬆️
#webui 61.88% <100%> (+0.01%) ⬆️

@ChrisBr ChrisBr merged commit 57e69b0 into openSUSE:master Oct 9, 2017
@ChrisBr
Copy link
Member Author

ChrisBr commented Oct 10, 2017

@ismail deployed to build.o.o! Please have a look and provide some feedback!

@ismail
Copy link
Contributor

ismail commented Oct 10, 2017

I never noticed we had so many new package requests for Factory! :-) Though I see maintenance requests are treated as new too (in principle they are due to naming) but ignoring them would be nice. See the screenshot.
maint

@ChrisBr ChrisBr deleted the feature/show_new_package branch October 12, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants