Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: improve layout of /request/show #3184

Closed
jengelh opened this issue Jun 2, 2017 · 0 comments
Closed

webui: improve layout of /request/show #3184

jengelh opened this issue Jun 2, 2017 · 0 comments

Comments

@jengelh
Copy link
Contributor

jengelh commented Jun 2, 2017

Happens on e.g. https://build.opensuse.org/request/show/498654

Observed result

The list of comment for the SR is vertically separated from the accept/decline textbox, sometimes by a lot. It is easy to miss/ignore them, especially if there is a sufficiently long request history.

Expected result

Comments should be placed above the accept/decline box, as the comments may contain information that have to influence a decision [opensuse-review-team].
ChrisBr added a commit to ChrisBr/open-build-service that referenced this issue Jun 29, 2017
@ChrisBr
[webui] Flip comment and accept boxes
6ef2510 
on request#show view because before it was easy to oversee comments.
openSUSE#3184
@ChrisBr ChrisBr mentioned this issue Jun 29, 2017
Merged
@ChrisBr ChrisBr closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisBr @jengelh