meshesPath & particlesPath: optional #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
approved these changes
Jan 23, 2018
|
Great change. I'll implement it in the openPMD-viewer. |
ax3l
changed the title
ax3l
changed the title
ax3l
changed the title
DavidSagan
approved these changes
Jan 23, 2018
Makes the base attributes `meshesPath` and `particlesPath` optional if no meshes or no particles shall be stored. Specifies that the path they describe MUST exist as soon as they are set. If they are unset, this MUST be interpreted as "no respective record".
ax3l
force-pushed
the
topic-onlyMeshOrPart
branch
from
b8892ab
to
9839c8f
Compare
|
@DavidSagan thx for the review, fixed! |
|
Should we merge this now? |
|
all right! :) |
This was referenced Jan 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the base attributes
meshesPathandparticlesPathoptional if no meshes or no particles shall be stored. Specifies that the path they describe MUST exist as soon as they are set. If they are unset, this MUST be interpreted as "no respective record".Implements issue: #143 (cc @mccoys)
Description
See comment in the original issue:
Affected Components
baseLogic Changes
if set, same parser logic as before, but it is now required that the path in the attributes is valid (does exist as a group).
If unset, interpret as "no particle/mesh" records found, respectively.
Writer Changes
No effect for before-valid files.
"Work-arounds" for particle-only/mesh-only openPMD files must now make sure that the path in
meshesPath/orparticlesPath/does really exist, since that behavior was unspecified so far. If not needed, they are now allowed to skip an attribute.Reader Changes
openPMD-validator: relax validator, check path exists if set: meshesPath & particlesPath: optional openPMD-validator#32openPMD-viewer: Fix viewer in the absence of mesh fields openPMD-viewer#184 Implement optional particle and mesh path openPMD-viewer#186yt: Updated and hardened openPMD frontend yt-project/yt#1645openPMD-visit-plugin: relaxation of reader needed? cc @xxirii @GBlaclardData Converter
No effect, old files are forward compatible to this change.