Better Examples for axisLabels #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a wording change of the openPMD 1.0.0 standard. Description Adds more detailed examples on the `dataOrder` in `axisLabels` attributes for C- and Fortran-style readers and writers. Affected Components - `base` Logic Changes No changes introduced. Writer Changes No data writers affected. Reader Changes No data readers affected. Data Converter No data conversion needed.
ax3l
added
the
revision change
|
@RemiLehe ping :) please review & merge me :) |
RemiLehe
approved these changes
Nov 27, 2017
|
Sounds good to me :) Thanks for the PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wording change of the openPMD 1.0.0 standard as porposed in #130.
Description
Adds more detailed examples on the
dataOrderinaxisLabelsattributes for C- and Fortran-style readers and writers.Examples:
cartesianC-styleA[z,y,x]write:("z", "y", "x")anddataOrder='C'cartesianC-styleA[y,x]write:("y", "x")anddataOrder='C'cartesianFortran-styleA[x,y]write:("x", "y")anddataOrder='F'thetaModeFortran-styleA[r,z]write:("r", "z")anddataOrder='F'Affected Components
baseLogic Changes
No changes introduced.
Writer Changes
No data writers affected.
Reader Changes
No data readers affected.
Data Converter
No data conversion needed.