Add Missing Virtual Destructors #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
fix-overwriteVirtualDestructors
branch
from
0076352 to
873b8f9
Compare
Active further virtual override checks in clang tidy.
ax3l
force-pushed
the
fix-overwriteVirtualDestructors
branch
3 times, most recently
from
3ffa5a9 to
404c0d3
Compare
As soon as a class implements virtual functions, it must also provide a virtual destructor.
override implies virtual, add more destructors to classes, add default where appropriate.
ax3l
force-pushed
the
fix-overwriteVirtualDestructors
branch
from
404c0d3 to
f1d42b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destructors don'tthey do: isocpp/CppCoreGuidelines@5fdfb20overrideC.128: Should destructors be marked "override"? isocpp/CppCoreGuidelines#721 (all other virtual member functions do)virtualmember function in a class triggers need forvirtual ~Typedestructor: https://www.geeksforgeeks.org/virtual-destructor/Related to #631