Bugs: Missing Virtual Destructors

As soon as a class implements virtual functions, it must also provide a virtual destructor.
openPMD · Dec 13, 2019 · 7d5b0ce · 7d5b0ce
1 parent c011917
commit 7d5b0ce
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/include/openPMD/Iteration.hpp b/include/openPMD/Iteration.hpp
@@ -90,6 +90,7 @@ class Iteration : public Attributable
     Container< Mesh > meshes;
     Container< ParticleSpecies > particles; //particleSpecies?
 
+    virtual ~Iteration() = default;
 private:
     Iteration();
 

diff --git a/include/openPMD/RecordComponent.hpp b/include/openPMD/RecordComponent.hpp
@@ -159,6 +159,8 @@ class RecordComponent : public BaseRecordComponent
 
     static constexpr char const * const SCALAR = "\vScalar";
 
+    virtual ~RecordComponent() = default;
+
 OPENPMD_protected:
     RecordComponent();
 

diff --git a/include/openPMD/backend/BaseRecord.hpp b/include/openPMD/backend/BaseRecord.hpp
@@ -57,7 +57,7 @@ class BaseRecord : public Container< T_elem >
 
     BaseRecord(BaseRecord const& b);
     BaseRecord& operator=(BaseRecord const& b);
-    ~BaseRecord() override { }
+    virtual ~BaseRecord() = default;
 
     mapped_type& operator[](key_type const& key) override;
     mapped_type& operator[](key_type&& key) override;

diff --git a/src/IO/AbstractIOHandlerHelper.cpp b/src/IO/AbstractIOHandlerHelper.cpp
@@ -18,11 +18,11 @@
  * and the GNU Lesser General Public License along with openPMD-api.
  * If not, see <http://www.gnu.org/licenses/>.
  */
-#include <openPMD/IO/ADIOS/ADIOS2IOHandler.hpp>
 #include "openPMD/IO/AbstractIOHandlerHelper.hpp"
 #include "openPMD/IO/DummyIOHandler.hpp"
 #include "openPMD/IO/ADIOS/ADIOS1IOHandler.hpp"
 #include "openPMD/IO/ADIOS/ParallelADIOS1IOHandler.hpp"
+#include "openPMD/IO/ADIOS/ADIOS2IOHandler.hpp"
 #include "openPMD/IO/HDF5/HDF5IOHandler.hpp"
 #include "openPMD/IO/HDF5/ParallelHDF5IOHandler.hpp"
 #include "openPMD/IO/JSON/JSONIOHandler.hpp"