Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky inactivity timer test #670

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Sep 3, 2024

Closes #669

There was a race condition between both channels in ChannelReceivesSomething having data.
The reason why this race condition appears only now is likely that the small delay of <-time.After(0) got reduced with the timer refactoring of Go 1.23.

@mpass99 mpass99 requested a review from MrSerth September 3, 2024 11:56
@mpass99 mpass99 self-assigned this Sep 3, 2024
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome finding, thanks! Happy to see that it only affects the tests, but not code we run in production. Thanks for taking care and linking it to Go 1.23

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (e89ce3b) to head (3d79e0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   76.28%   76.19%   -0.09%     
==========================================
  Files          43       43              
  Lines        3592     3592              
==========================================
- Hits         2740     2737       -3     
- Misses        623      625       +2     
- Partials      229      230       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpass99 mpass99 merged commit da0cd25 into main Sep 3, 2024
12 checks passed
@mpass99 mpass99 deleted the fix/#669-flaky-inactivity-timer branch September 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky unit test
2 participants