Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner replacement on recovery #667

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Sep 2, 2024

by now just updating the port mapping.

Closes #651

@mpass99 mpass99 requested a review from MrSerth September 2, 2024 15:02
@mpass99 mpass99 self-assigned this Sep 2, 2024
@mpass99 mpass99 mentioned this pull request Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.19%. Comparing base (990b7f3) to head (592d727).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/nomad_manager.go 43.75% 6 Missing and 3 partials ⚠️
internal/runner/nomad_runner.go 68.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   76.21%   76.19%   -0.02%     
==========================================
  Files          43       43              
  Lines        3565     3592      +27     
==========================================
+ Hits         2717     2737      +20     
- Misses        624      625       +1     
- Partials      224      230       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

There are still many annotations, mostly from the linter -- please double check these. After fixing all other linter issues, the pipeline should generally pass 😉

by now just updating the port mapping.
@mpass99 mpass99 force-pushed the fix/#651-used-runner-recovery branch from e2372a9 to 592d727 Compare September 3, 2024 08:55
@MrSerth
Copy link
Member

MrSerth commented Sep 3, 2024

I just observed another occurrence of #669.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Let's give it a try 😉

@mpass99 mpass99 merged commit e89ce3b into main Sep 3, 2024
11 of 12 checks passed
@mpass99 mpass99 deleted the fix/#651-used-runner-recovery branch September 3, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry: the runner will be destroyed and replaced
2 participants