Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing link target #662

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Fix missing link target #662

merged 2 commits into from
Sep 2, 2024

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Aug 20, 2024

for listing the file system with a link, the executing user does not have enough privileges to read the target.

Closes #596

@mpass99 mpass99 self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.38%. Comparing base (f848fee) to head (14a7205).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/nomad_runner.go 28.57% 5 Missing ⚠️
pkg/nullio/ls2json.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   76.20%   76.38%   +0.18%     
==========================================
  Files          43       43              
  Lines        3551     3557       +6     
==========================================
+ Hits         2706     2717      +11     
+ Misses        620      617       -3     
+ Partials      225      223       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpass99 mpass99 force-pushed the fix/#596-link-target-denied branch from 5758a0e to 64229ed Compare August 20, 2024 13:29
@mpass99 mpass99 marked this pull request as ready for review August 20, 2024 13:29
@mpass99 mpass99 requested a review from MrSerth August 20, 2024 13:29
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I tested the branch locally and can confirm that your patch resolves the issue for me.

There is one question left, though: When listing files where this (former) bug triggers, I still have an exit code 1 and thus the following warning: level=warning msg="Ignoring error of listing the file system" error="<nil>" exitCode=1 package=runner. Do we just continue to ignore it (and log as warning) or do we want to do something special (since we know why the error was generated in the first place....)

pkg/nullio/ls2json.go Show resolved Hide resolved
@mpass99 mpass99 force-pushed the fix/#596-link-target-denied branch from 64229ed to 3be6d03 Compare August 21, 2024 14:30
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, works like a charm. Thanks!

for listing the file system with a link, the executing user has not enough privileges to read the target.
@MrSerth
Copy link
Member

MrSerth commented Sep 2, 2024

I've created an issue for the flaky unit test #669.

@MrSerth
Copy link
Member

MrSerth commented Sep 2, 2024

I've also amended ticket #623 for the failed e2e test. It seems like we need to investigate in the test suite, once again.

@MrSerth MrSerth merged commit 13b33b0 into main Sep 2, 2024
11 of 12 checks passed
@MrSerth MrSerth deleted the fix/#596-link-target-denied branch September 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not split link into name and target
2 participants