-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Sentry issues #634
Group Sentry issues #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving the error handler; I hope this will make it easier to recognize the error by allowing a global count for this type of race condition. 👍
Once we merged and deployed this issue, we should probably follow-up and sort / merge some of the Sentry issues, too. Can you please do so (since you know better which ones are related)? |
7f2d6ba
to
db4d4c3
Compare
503261d
to
00611d6
Compare
by throwing the log warning at the common level of the Execute call and not at multiple places relying on it.
00611d6
to
de5bb88
Compare
I just deployed the latest version of Poseidon to production and staging, allowing us to take care of the Sentry issues (merging, ...). |
I just resolved POSEIDON-3W and POSEIDON-3V. This allows us to notice when these high-level issues reoccur because of a different low-level error. |
Thanks! As mentioned in the ticket #589, we need to make some further adjustments before resolving POSEIDON-3W again (since it was regressed). |
by throwing the log warning at the common level of the Execute call and not at multiple places relying on it.
Related to #589