Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Sentry issues #634

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Group Sentry issues #634

merged 1 commit into from
Aug 1, 2024

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Jul 23, 2024

by throwing the log warning at the common level of the Execute call and not at multiple places relying on it.

Related to #589

@mpass99 mpass99 requested a review from MrSerth July 23, 2024 22:42
@mpass99 mpass99 self-assigned this Jul 23, 2024
MrSerth
MrSerth previously approved these changes Aug 1, 2024
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the error handler; I hope this will make it easier to recognize the error by allowing a global count for this type of race condition. 👍

@MrSerth
Copy link
Member

MrSerth commented Aug 1, 2024

Once we merged and deployed this issue, we should probably follow-up and sort / merge some of the Sentry issues, too. Can you please do so (since you know better which ones are related)?

@MrSerth MrSerth force-pushed the fix/#619-update-fs-logs branch 2 times, most recently from 7f2d6ba to db4d4c3 Compare August 1, 2024 21:27
@MrSerth MrSerth force-pushed the fix/#589-group-unxpected-eof branch from 503261d to 00611d6 Compare August 1, 2024 21:32
Base automatically changed from fix/#619-update-fs-logs to main August 1, 2024 21:32
@MrSerth MrSerth dismissed their stale review August 1, 2024 21:32

The base branch was changed.

by throwing the log warning at the common level of the Execute call and not at multiple places relying on it.
@MrSerth MrSerth force-pushed the fix/#589-group-unxpected-eof branch from 00611d6 to de5bb88 Compare August 1, 2024 21:34
@MrSerth MrSerth enabled auto-merge (rebase) August 1, 2024 21:36
@MrSerth MrSerth merged commit 932070f into main Aug 1, 2024
10 checks passed
@MrSerth MrSerth deleted the fix/#589-group-unxpected-eof branch August 1, 2024 21:40
@MrSerth
Copy link
Member

MrSerth commented Aug 1, 2024

I just deployed the latest version of Poseidon to production and staging, allowing us to take care of the Sentry issues (merging, ...).

@mpass99
Copy link
Collaborator Author

mpass99 commented Aug 7, 2024

I just resolved POSEIDON-3W and POSEIDON-3V. This allows us to notice when these high-level issues reoccur because of a different low-level error.
I hope to see another unexpected EOF error soon creating its own Sentry issue so we can verify that the error check of this PR is working.

@MrSerth
Copy link
Member

MrSerth commented Aug 7, 2024

Thanks! As mentioned in the ticket #589, we need to make some further adjustments before resolving POSEIDON-3W again (since it was regressed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants