Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine updateFileSystem logging messages #633

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

mpass99
Copy link
Collaborator

@mpass99 mpass99 commented Jul 23, 2024

to be able to differentiate between the different errors that occur.

Closes #619

@mpass99 mpass99 requested a review from MrSerth July 23, 2024 11:26
@mpass99 mpass99 self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 76.63%. Comparing base (8f819de) to head (66561e7).
Report is 4 commits behind head on main.

Files Patch % Lines
internal/api/runners.go 33.33% 12 Missing ⚠️
internal/nomad/api_querier.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   76.92%   76.63%   -0.30%     
==========================================
  Files          41       41              
  Lines        3498     3514      +16     
==========================================
+ Hits         2691     2693       +2     
- Misses        592      606      +14     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MrSerth
MrSerth previously approved these changes Aug 1, 2024
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! That's great to see and I really expect it will aid us in identifying further issues and prioritize them 💪

to be able to differentiate between the different errors that occur.
@MrSerth MrSerth enabled auto-merge (rebase) August 1, 2024 21:28
@MrSerth MrSerth merged commit 84166e1 into main Aug 1, 2024
10 checks passed
@MrSerth MrSerth deleted the fix/#619-update-fs-logs branch August 1, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor updateFileSystem Error logging
2 participants