Release runner in case of errors #2520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a runner was not released in case of an `Runner::Error`. Especially when a runner was not found (i.e., when executing an arbitrary command), a `Runner::Error::RunnerNotFound` exception was thrown. Then, the automatic request for a new runner failed, since the previous runner was still in use.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2520 +/- ##
==========================================
+ Coverage 69.37% 69.40% +0.03%
==========================================
Files 199 199
Lines 6347 6347
==========================================
+ Hits 4403 4405 +2
+ Misses 1944 1942 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a runner was not released in case of an
Runner::Error. Especially when a runner was not found (i.e., when executing an arbitrary command), aRunner::Error::RunnerNotFoundexception was thrown. Then, the automatic request for a new runner failed, since the previous runner was still in use.