Skip to content

Commit

Permalink
Fix unnecessary testrun for each successful test / score action.
Browse files Browse the repository at this point in the history
This commit resolves a regression introduced by commit 9c3ec3c.

We still might want to remove this false data from our database, which is still pending.
  • Loading branch information
MrSerth committed Jul 15, 2023
1 parent a630f70 commit 264927e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/controllers/submissions_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ def score
kill_client_socket(client_socket)
Rails.logger.debug { "Runner error while scoring submission #{@submission.id}: #{e.message}" }
@testrun[:passed] = false
ensure
save_testrun_output 'assess'
end

Expand Down Expand Up @@ -297,7 +296,6 @@ def test
kill_client_socket(client_socket)
Rails.logger.debug { "Runner error while testing submission #{@submission.id}: #{e.message}" }
@testrun[:passed] = false
ensure
save_testrun_output 'assess'
end

Expand Down

0 comments on commit 264927e

Please sign in to comment.