Skip to content

Commit

Permalink
Language Selector: Prevent duplicate locale= keys
Browse files Browse the repository at this point in the history
  • Loading branch information
MrSerth committed Jun 23, 2023
1 parent 9b7fd0f commit 1296a12
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/helpers/authenticated_url_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def add_query_parameters(url, parameters)
parsed_url = URI.parse url

# Add the given parameters to the query string
query_params = CGI.parse(parsed_url.query || '')
query_params = CGI.parse(parsed_url.query || '').with_indifferent_access
query_params.merge!(parameters)

# Add the query string back to the URL
Expand Down
15 changes: 15 additions & 0 deletions spec/helpers/authenticated_url_helper_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# frozen_string_literal: true

require 'rails_helper'

describe AuthenticatedUrlHelper do
describe '#add_query_parameters' do
it 'adds the given parameters to the given url' do
expect(described_class.add_query_parameters(root_url, {foo: 'bar'})).to eq(root_url(foo: 'bar'))
end

it 'does not duplicate existing parameters' do
expect(described_class.add_query_parameters(root_url(foo: 'bar'), {foo: 'baz'})).to eq(root_url(foo: 'baz'))
end
end
end

0 comments on commit 1296a12

Please sign in to comment.