Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#120] bring netcat back #121

Merged
merged 2 commits into from
Dec 7, 2023
Merged

🐛 [#120] bring netcat back #121

merged 2 commits into from
Dec 7, 2023

Conversation

annashamray
Copy link
Contributor

fixes #120

@annashamray annashamray marked this pull request as ready for review December 6, 2023 09:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978b957) 89.24% compared to head (3501e35) 89.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files          82       82           
  Lines        2036     2036           
  Branches      236      236           
=======================================
  Hits         1817     1817           
  Misses        194      194           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure we know why this was added.

Dockerfile Show resolved Hide resolved
Co-authored-by: Joeri Bekker <96970+joeribekker@users.noreply.github.com>
@alextreme alextreme merged commit 7ac5ce0 into main Dec 7, 2023
10 checks passed
@alextreme alextreme deleted the issue/120-netcat branch December 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ON 1.5: lack of netcat causes celery to not start
4 participants