Skip to content

Commit

Permalink
✅ [open-zaak/open-zaak#1203] Tests for notif retry setup config
Browse files Browse the repository at this point in the history
  • Loading branch information
stevenbal committed Apr 16, 2024
1 parent c66ad80 commit 55e6370
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/nrc/tests/commands/test_setup_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from zgw_consumers.test import mock_service_oas_get

from nrc.config.authorization import AuthorizationStep, OpenZaakAuthStep
from nrc.config.notification_retry import NotificationRetryConfigurationStep
from nrc.config.site import SiteConfigurationStep


Expand All @@ -29,6 +30,8 @@
OPENZAAK_NOTIF_SECRET="oz-secret",
)
class SetupConfigurationTests(TestCase):
maxDiff = None

def setUp(self):
super().setUp()

Expand Down Expand Up @@ -66,13 +69,15 @@ def test_setup_configuration(self, m):
command_output = stdout.getvalue().splitlines()
expected_output = [
f"Configuration will be set up with following steps: [{SiteConfigurationStep()}, "
f"{AuthorizationStep()}, {OpenZaakAuthStep()}]",
f"{AuthorizationStep()}, {OpenZaakAuthStep()}, {NotificationRetryConfigurationStep()}]",
f"Configuring {SiteConfigurationStep()}...",
f"{SiteConfigurationStep()} is successfully configured",
f"Configuring {AuthorizationStep()}...",
f"{AuthorizationStep()} is successfully configured",
f"Configuring {OpenZaakAuthStep()}...",
f"{OpenZaakAuthStep()} is successfully configured",
f"Configuring {NotificationRetryConfigurationStep()}...",
f"{NotificationRetryConfigurationStep()} is successfully configured",
"Instance configuration completed.",
]

Expand Down
31 changes: 31 additions & 0 deletions src/nrc/tests/config/test_notification_retry_configuration.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
from django.test import TestCase, override_settings

from notifications_api_common.models import NotificationsConfig

from nrc.config.notification_retry import NotificationRetryConfigurationStep


@override_settings(
NOTIFICATION_DELIVERY_MAX_RETRIES=4,
NOTIFICATION_DELIVERY_RETRY_BACKOFF=5,
NOTIFICATION_DELIVERY_RETRY_BACKOFF_MAX=6,
)
class NotificationRetryConfigurationTests(TestCase):
def test_configure(self):
configuration = NotificationRetryConfigurationStep()
configuration.configure()

config = NotificationsConfig.get_solo()

self.assertEqual(config.notification_delivery_max_retries, 4)
self.assertEqual(config.notification_delivery_retry_backoff, 5)
self.assertEqual(config.notification_delivery_retry_backoff_max, 6)

def test_is_configured(self):
configuration = NotificationRetryConfigurationStep()

self.assertFalse(configuration.is_configured())

configuration.configure()

self.assertTrue(configuration.is_configured())

0 comments on commit 55e6370

Please sign in to comment.